Refactor Archiver and add BaseHead #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokovninn
commented
Nov 26, 2024
|
I've updated only the |
kozlov721
reviewed
Nov 26, 2024
klemen1999
reviewed
Nov 27, 2024
sokovninn
changed the title
sokovninn
requested review from
kozlov721,
klemen1999,
tersekmatija and
conorsim
and removed request for
a team
klemen1999
reviewed
Nov 27, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Co-authored-by: KlemenSkrlj <[email protected]>
…uxonis-train into feat/archiver-refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
- Coverage 96.31% 95.14% -1.18%
==========================================
Files 147 164 +17
Lines 6304 7144 +840
==========================================
+ Hits 6072 6797 +725
- Misses 232 347 +115 ☔ View full report in Codecov by Sentry. |
kozlov721
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
BaseHeadclass to standardize head definitions in the NN architecture. The new class enforces required fields likeparserand provides a structured way to define head-specific metadata viaget_custom_head_config.Additionally, the archiver has been refactored to utilize the
BaseHeadclass for generating configurations, reducing redundancy and improving scalability when adding new architectures. This ensures auxiliary heads and other metadata are handled consistently.Key Changes:
BaseHeadclass with aparserfield._get_base_head_configandget_custom_head_configfor better separation of base and custom logic.BaseHeadinstances instead of relying solely on the config file.